Skip to content

Update the !include paths to point to the new release URL. #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kirchsth merged 1 commit into from
Dec 3, 2022
Merged

Update the !include paths to point to the new release URL. #270

kirchsth merged 1 commit into from
Dec 3, 2022

Conversation

@Potherca
Copy link
Member

@Potherca Potherca commented Dec 3, 2022

No description provided.

@Potherca Potherca added this to the v2.5.0 milestone Dec 3, 2022
@Potherca Potherca requested a review from kirchsth December 3, 2022 15:01
@Potherca Potherca self-assigned this Dec 3, 2022
kirchsth
kirchsth requested changes Dec 3, 2022
View reviewed changes
Copy link
Member

@kirchsth kirchsth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a) I think this merge is in the wrong direction (C4_* from master should still reference master)
b) and the used reference https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/v2.5.0/C4_Container.puml
is not working

@startuml
!include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/v2.5.0/C4_Container.puml

Person(admin, "Administrator")
System_Boundary(c1, "Sample System") {
    Container(web_app, "Web Application", "C#, ASP.NET Core 2.1 MVC", "Allows users to compare multiple Twitter timelines")
}
System(twitter, "Twitter")

Rel(admin, web_app, "Uses", "HTTPS")
Rel(web_app, twitter, "Gets tweets from", "HTTPS")
@enduml

@Potherca
Copy link
Member Author

Potherca commented Dec 3, 2022

The https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/v2.5.0/C4_*.puml references don't work as there is no v2.5.0 yet. I could tag this commit to make things work now but then I'd just have to delete the tag again to be able to tag a release (on master).

I was planning on deleting the release/2.5.0 branch after this is merged, and changing the reference back to master once v2.5.0 has been tagged.

@kirchsth
Copy link
Member

kirchsth commented Dec 3, 2022

Thank you for the explanation (next time I will update the branches with the correct branches ;-) )

@kirchsth kirchsth merged commit d729c55 into master Dec 3, 2022
@kirchsth kirchsth mentioned this pull request Dec 4, 2022
Closed
@kirchsth kirchsth deleted the release/2.5.0 branch December 11, 2022 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirchsth kirchsth kirchsth approved these changes

Assignees

@Potherca Potherca

Labels

None yet

Projects

All Projects
Status: Done

Milestone

v2.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Potherca @kirchsth